SpeedyWeather v0.19 compat by maximilian-gelbrecht · Pull Request #133 · NumericalEarth/NumericalEarth.jl

maximilian-gelbrecht · 2026-03-16T08:24:12Z

Fixes #132

simone-silvestri · 2026-03-16T08:33:40Z

Ah apparently we were restricting the version of SpeedyWeather, that is why the tests were still passing

maximilian-gelbrecht · 2026-03-16T08:36:12Z

I think right at the moment that's actually also still a fair assumption to restrict versions. One of the next releases of SpeedyWeather will also def break this again, as we are rewriting the variable system. So restricting the version ensures it actually still works.

simone-silvestri · 2026-03-16T08:38:19Z

Ok, so shall we keep this PR open such that we can update SpeedyWeather in one go when you guys finished with the variables refactor and in the meantime just add a warning when we load the extension if v > 0.17?

maximilian-gelbrecht · 2026-03-16T08:41:39Z

I don't know. I mean this here is just a quick fix, and makes it run with v0.18. Isn't that good in itself?

We'll likely merge the new variable system next week or in two weeks and then wait a bit more for a proper release, and then we could just another small PR. It's just a few lines of code that change here.

navidcy · 2026-03-16T09:35:26Z

I think the compat entry for v0.18.1 that this PR adds is appropriate.
Let's merge this. From now on, we support only v0.18.1 or later.
Perhaps that deserves a patch release of NumericalEarth

navidcy · 2026-03-16T09:38:48Z

@maximilian-gelbrecht, after the SpeedyWeather v0.18.1+ that this PR introduces, does it make sense to run the atmosphere in the global_cloupled_simulation.jl example on the GPU?

maximilian-gelbrecht · 2026-03-16T09:41:29Z

As of now, the GPU version is running and also part of the released version, but we don't really consider it fully finished. We invested a good amount of time into the parametrizations, but the dynamical core still needs some optimisations to run more efficiently on GPU.

navidcy · 2026-03-16T09:45:53Z

Cool; let's leave transitioning the atmosphere part of the example to GPU for later.

codecov · 2026-03-16T10:05:01Z

Codecov Report

❌ Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...lEarthSpeedyWeatherExt/speedy_weather_exchanger.jl	0.00%	14 Missing ⚠️
...hSpeedyWeatherExt/speedy_atmosphere_simulations.jl	0.00%	7 Missing ⚠️

📢 Thoughts on this report? Let us know!

maximilian-gelbrecht · 2026-03-16T10:17:02Z

I realised this actually needs a few more minor changes due to other changes to the variables system we did since 0.17.4, not only the signature of the parametrization_tendencies!.

Nothing really major on the NumericalEarth side here, as far as I can see it. Will address those later.

navidcy · 2026-03-16T11:21:09Z

Let me know when it’s ready to have a look

simone-silvestri · 2026-03-16T13:41:56Z


 Base.summary(::SpeedySimulation) = "SpeedyWeather.Simulation"

+# TODO: This is a temporary solution to tell SpeedyWeather to allocate the ocean variables, without having an ocean. In SpeedyWeather PR#969 it will be addressed slightly more properly.


I guess in the future we want to have ocean=nothing in speedyweather and then we just compute everything here?

This is just there because we introduced the first of part of new variable system in 0.18, and it was an oversight of us to not always allocate the sea_surface_temperature somewhere, even with ocean=nothing. SpeedyWeather/SpeedyWeather.jl#969 is the second part of that. We just have to decide where to allocate the sea_surface_temperature (and similar variables for land and sea ice). Once we do that, you can probably do ocean=nothing again.

So yeah, this is just about memory allocation, and not about computations. Those are all here / in Oceananigans anyway.

We went with PrescribedOcean() for now. I think this also makes sense in this case. The ocean isn't non-existent / nothing it is prescribed by NumericalEarth. PrescribedOcean just makes sure that we have the proper variables allocated to be written into by NumericalEarth.

…ns.jl Co-authored-by: Navid C. Constantinou <navidcy@users.noreply.github.com>

maximilian-gelbrecht · 2026-04-23T14:12:52Z

I just updated this to version 0.19 that we just released. I still have to check if it actually works.

Locally, I have some trouble running the tests because of a version conflict between Oceananigans and NumericalEarth in the test env. I am a bit confused by that.

maximilian-gelbrecht · 2026-04-23T14:30:26Z

My update is just adjusting for syntax changes. We could probably also think about actually using ConservativeRegridding in a follow up, or is it still not ready?

Edit: Ah, I see that's already part of #160

Co-authored-by: Copilot <copilot@github.com>

maximilian-gelbrecht · 2026-04-23T15:09:54Z

Sorry, this took me a bit, but now the Speedy coupling test passes locally.

simone-silvestri · 2026-04-27T15:26:18Z

I think this is ready to merge

simone-silvestri · 2026-04-28T08:17:36Z

Tests are not passing because this is a fork that does not have access to the credentials which are repository secrets. I will merge anyways because the speedy weather coupling tests pass

maximilian-gelbrecht added 2 commits March 16, 2026 09:16

Speedy 0.18 compat

245c986

revert some accidental automatic formatting

280a294

simone-silvestri approved these changes Mar 16, 2026

View reviewed changes

test deps as well for Speedy

b07254e

navidcy reviewed Mar 16, 2026

View reviewed changes

Comment thread Project.toml Outdated

navidcy approved these changes Mar 16, 2026

View reviewed changes

Update Project.toml

5e0da96

navidcy added atmosphere ⛈️ where the weather happens extension 🧬 labels Mar 16, 2026

maximilian-gelbrecht mentioned this pull request Mar 16, 2026

One Variables 💍 to hold them all SpeedyWeather/SpeedyWeather.jl#969

Merged

added PrescribedOcean + running locally

ccc3012

maximilian-gelbrecht requested a review from navidcy March 16, 2026 13:10

simone-silvestri reviewed Mar 16, 2026

View reviewed changes

Merge branch 'main' into mg/speedy0-18

53e1cda

navidcy reviewed Mar 17, 2026

View reviewed changes

Comment thread ext/NumericalEarthSpeedyWeatherExt/speedy_atmosphere_simulations.jl Outdated

navidcy reviewed Mar 17, 2026

View reviewed changes

Comment thread ext/NumericalEarthSpeedyWeatherExt/speedy_atmosphere_simulations.jl Outdated

maximilian-gelbrecht and others added 2 commits March 17, 2026 18:00

Update ext/NumericalEarthSpeedyWeatherExt/speedy_atmosphere_simulatio…

1ecbf8a

…ns.jl Co-authored-by: Navid C. Constantinou <navidcy@users.noreply.github.com>

Merge branch 'main' into mg/speedy0-18

42e2f61

navidcy mentioned this pull request Mar 19, 2026

Rename variable_reference to reference_variable SpeedyWeather/SpeedyWeather.jl#1010

Closed

simone-silvestri mentioned this pull request Apr 23, 2026

Docs not building on main #185

Closed

SpeedyWeather 0.19

d230e5d

maximilian-gelbrecht changed the title ~~SpeedyWeather v0.18 compat~~ SpeedyWeather v0.19 compat Apr 23, 2026

Merge branch 'main' into mg/speedy0-18

34268e9

maximilian-gelbrecht and others added 5 commits April 23, 2026 16:33

physics -> parameterizations

7c78442

physics -> parameterizations (ii)

fdda2c1

long variable names

7ba824f

reset_tendencies!

37db5a6

Co-authored-by: Copilot <copilot@github.com>

locally test pass

91d2111

maximilian-gelbrecht requested a review from simone-silvestri April 23, 2026 15:09

adjust speedy coupling test

d037f4b

This was referenced Apr 24, 2026

CompatHelper: bump compat for SpeedyWeather in [weakdeps] to 0.19, (keep existing compat) #188

Closed

(0.17.5) update SpeedyWeatherInternals compat SpeedyWeather/SpeedyWeather.jl#1070

Merged

Merge branch 'main' into mg/speedy0-18

cb1210a

simone-silvestri approved these changes Apr 27, 2026

View reviewed changes

simone-silvestri merged commit 4a1bb91 into NumericalEarth:main Apr 28, 2026
4 of 9 checks passed


		Base.summary(::SpeedySimulation) = "SpeedyWeather.Simulation"

		# TODO: This is a temporary solution to tell SpeedyWeather to allocate the ocean variables, without having an ocean. In SpeedyWeather PR#969 it will be addressed slightly more properly.

Conversation

maximilian-gelbrecht commented Mar 16, 2026

Uh oh!

simone-silvestri commented Mar 16, 2026

Uh oh!

maximilian-gelbrecht commented Mar 16, 2026

Uh oh!

simone-silvestri commented Mar 16, 2026

Uh oh!

maximilian-gelbrecht commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

navidcy commented Mar 16, 2026

Uh oh!

Uh oh!

navidcy commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maximilian-gelbrecht commented Mar 16, 2026

Uh oh!

navidcy commented Mar 16, 2026

Uh oh!

codecov Bot commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

maximilian-gelbrecht commented Mar 16, 2026

Uh oh!

navidcy commented Mar 16, 2026

Uh oh!

simone-silvestri Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

maximilian-gelbrecht Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maximilian-gelbrecht Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

maximilian-gelbrecht commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maximilian-gelbrecht commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maximilian-gelbrecht commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

simone-silvestri commented Apr 27, 2026

Uh oh!

simone-silvestri commented Apr 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

maximilian-gelbrecht commented Mar 16, 2026 •

edited

Loading

navidcy commented Mar 16, 2026 •

edited

Loading

codecov Bot commented Mar 16, 2026 •

edited

Loading

maximilian-gelbrecht Mar 16, 2026 •

edited

Loading

maximilian-gelbrecht commented Apr 23, 2026 •

edited

Loading

maximilian-gelbrecht commented Apr 23, 2026 •

edited

Loading

maximilian-gelbrecht commented Apr 23, 2026 •

edited

Loading